fix: payments irrespective of party types (backport #37828) #43040
Conversation
dj12djdjs
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
@dj12djdjs did you also consider this follow-up to the original PR? #38071 Also, these validations we're removing in the backend still exist in the frontend, even on the develop branch: erpnext/erpnext/accounts/doctype/payment_entry/payment_entry.js Lines 1089 to 1107 in 0633484 Is this on purpose? |
|
@barredterra I noticed that, my customer wasn't to picky about it and just ignored the popup. It should be removed from the frontend. Will rebase and remove that logic. |
# Reference: frappe@58114e7
# Reference: frappe@58114e7
dj12djdjs
force-pushed
the
backport/version-14-hotfix/37828-1
branch
from
2f2afca to
1c3ea83
Compare
| return false; | ||
| } | ||
| } else { | ||
| if(paid_amount < total_negative_outstanding) { |
There was a problem hiding this comment.
@barredterra I think it makes sense to reverse the original if condition since we're removing the path that triggered the validation. I haven't spent much time reading this section of PE logic. Do you have any initial doubts about this?
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
I didn't want to overwrite the changes in #38630 in case I've made an error during rebase.
continuation of: #38630
backport of: #37828